Wireshark-commits: [Wireshark-commits] master 655b0dc: use the captured length as payload length fo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Aug 2015 04:43:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=655b0dc623e29da212be3e205314624fe3182562
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

655b0dc by Martin Kaiser (wireshark@xxxxxxxxx):

    use the captured length as payload length for zigbee decryption
    
    this length is used for allocating a buffer and for crypto calculations
    we should use the bytes that were actually captured, not the reported
    length
    
    the capture in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11389
    has one packet with a stupidly large reported length and a reasonable
    capture length (and one completely bogus packet) - this fix ensures that
    the decryption does not break for the former packet
    
    also, tvb_reported_length_remaining() does not return values < 0 any
    more, remove the check for this
    
    Bug: 11389
    Change-Id: I42cb4526483160416b51e3cb72442148b5fac4f3
    Reviewed-on: https://code.wireshark.org/review/9950
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  aafc7ff   H225: fix no previous prototype for 'h225_stat_init' [-Wmissing-prototypes]
    adds  655b0dc   use the captured length as payload length for zigbee decryption


Summary of changes:
 epan/dissectors/packet-zbee-security.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)