Wireshark-commits: [Wireshark-commits] master a001ed6: Avoid (unlikely) NRB record size overflows.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 7 Aug 2015 22:28:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a001ed6f8a88d1870e1377fae3c73b4b5e7160e3
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a001ed6 by Guy Harris (guy@xxxxxxxxxxxx):

    Avoid (unlikely) NRB record size overflows.
    
    If a host name is *so* long that an entry for it won't fit in a
    65535-byte Name Resolution Block record, ignore the entry for that host.
    
    Use more appropriate data types (guint32 for sizes that are 32-bit
    unsigned integers, guint16 for the host name length as it'd better fit
    in 16 bits).
    
    Clean up some comments.
    
    Remove a _U_ that's applied to a variable that *is* used.
    
    Change-Id: I153d5aa885105149c62a5e5d2b78b54cf6ed7b4e
    Reviewed-on: https://code.wireshark.org/review/9917
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  817d9bd   Add SHA2 algos to certificate dissection in SSL
    adds  a001ed6   Avoid (unlikely) NRB record size overflows.


Summary of changes:
 wiretap/pcapng.c |   51 ++++++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 42 insertions(+), 9 deletions(-)