Wireshark-commits: [Wireshark-commits] master 4557c17: androiddump: Try to make MVS14.0 happy
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 7 Aug 2015 08:51:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4557c17f7aad5e26fb840ea90e51de9dabf94e68
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4557c17 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    androiddump: Try to make MVS14.0 happy
    
    I guess using glib's gssize instead of ssize_t should be enough for:
    
    extcap/androiddump.c(736): error C2220: warning treated as error - no 'object' f
    	ile generated
    extcap/androiddump.c(736): warning C4477: 'fprintf' : format string '%I64i' requ
    	ires an argument of type '__int64', but variadic argument 3 has type 'ssize_t'
    extcap/androiddump.c(736): note: to simplify migration, consider the temporary
    	use of /Wv:18 flag with the version of the compiler with which you used to
    	build without warnings
    extcap/androiddump.c(736): note: consider using '%i' in the format string
    extcap/androiddump.c(736): note: consider using '%I32i' in the format string
    
    Change-Id: I1030694aed61d413be1aad54531f99db45e99c9d
    Reviewed-on: https://code.wireshark.org/review/9876
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  dc33bba   [ieee80211] Change one ENC_LITTLE_ENDIAN MAC address to ENC_NA; byte order doesn't apply to them.
    adds  4557c17   androiddump: Try to make MVS14.0 happy


Summary of changes:
 extcap/androiddump.c |  374 +++++++++++++++++++++++++-------------------------
 1 file changed, 188 insertions(+), 186 deletions(-)