Wireshark-commits: [Wireshark-commits] master ff24ecc: Fixup stat_tap table freeing.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 6 Aug 2015 21:22:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ff24ecceb976e25cf58040b116f25fc218290540
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ff24ecc by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Fixup stat_tap table freeing.
    
    As it turns out we *do* need to free table elements. We also need to
    free the tables themselves and clear the table array. Do so.
    
    Change-Id: Ic1c81388eac8f47f74caea0169c79685a83aaff9
    Reviewed-on: https://code.wireshark.org/review/9901
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  9fd3bcc   Add an elide mode preference for the Qt packet list.
    adds  ff24ecc   Fixup stat_tap table freeing.


Summary of changes:
 asn1/camel/packet-camel-template.c     |    8 +++++++-
 asn1/gsm_map/packet-gsm_map-template.c |   18 +++++++++++++++---
 debian/libwireshark0.symbols           |    2 +-
 epan/dissectors/packet-camel.c         |   14 ++++++++++----
 epan/dissectors/packet-gsm_a_common.c  |   20 ++++++++++++++++----
 epan/dissectors/packet-gsm_map.c       |   24 ++++++++++++++++++------
 epan/stat_tap_ui.c                     |    7 ++++++-
 epan/stat_tap_ui.h                     |   14 +++++++++++++-
 ui/gtk/simple_stattable.c              |    4 ++--
 ui/qt/simple_statistics_dialog.cpp     |    4 ++--
 10 files changed, 90 insertions(+), 25 deletions(-)