Wireshark-commits: [Wireshark-commits] master b7f5eaa: Convert the GSM MAP stats to new "generic st
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 6 Aug 2015 01:59:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7f5eaa5243ab8f0f2912e406a7d0cb94ff0c9fb
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b7f5eaa by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Convert the GSM MAP stats to new "generic stat API".
    
    Convert both the MAP statistics and summary. As with the GSM A stats
    this are mostly untested.
    
    Change-Id: Ibd3a7346b09d1401e78724c0197ec2a38deb97a3
    Reviewed-on: https://code.wireshark.org/review/9883
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  05eb9b6   Add proper base prefixes in display filter expressions.
    adds  b7f5eaa   Convert the GSM MAP stats to new "generic stat API".


Summary of changes:
 asn1/gsm_map/packet-gsm_map-template.c             |  160 ++++++-
 asn1/gsm_map/packet-gsm_map-template.h             |    2 +-
 epan/dissectors/packet-gsm_map.c                   |  176 ++++++-
 epan/dissectors/packet-gsm_map.h                   |    2 +-
 ui/gtk/CMakeLists.txt                              |    1 -
 ui/gtk/Makefile.common                             |    2 -
 ui/gtk/gsm_map_stat.c                              |  494 --------------------
 ui/gtk/gsm_map_stat.h                              |   44 --
 ui/gtk/gsm_map_summary.c                           |   75 ++-
 ui/gtk/main_menubar.c                              |    2 -
 ui/qt/CMakeLists.txt                               |    3 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/Makefile.common                              |    2 +
 ui/qt/Wireshark.pro                                |    3 +
 ui/qt/capture_file_properties_dialog.cpp           |   19 +-
 ui/qt/capture_file_properties_dialog.h             |    1 -
 ui/qt/gsm_map_summary_dialog.cpp                   |  408 ++++++++++++++++
 ...xport_pdu_dialog.h => gsm_map_summary_dialog.h} |   30 +-
 ..._string_dialog.ui => gsm_map_summary_dialog.ui} |   20 +-
 ui/qt/main_window.cpp                              |    4 +
 ui/qt/main_window.h                                |    1 +
 ui/qt/main_window.ui                               |    8 +
 ui/qt/main_window_slots.cpp                        |    7 +
 ui/qt/qt_ui_utils.cpp                              |    8 +
 ui/qt/qt_ui_utils.h                                |    8 +
 25 files changed, 885 insertions(+), 597 deletions(-)
 delete mode 100644 ui/gtk/gsm_map_stat.c
 delete mode 100644 ui/gtk/gsm_map_stat.h
 create mode 100644 ui/qt/gsm_map_summary_dialog.cpp
 copy ui/qt/{export_pdu_dialog.h => gsm_map_summary_dialog.h} (67%)
 copy ui/qt/{funnel_string_dialog.ui => gsm_map_summary_dialog.ui} (74%)