Wireshark-commits: [Wireshark-commits] master ef0bdbc: Cleanup a bunch of 802.11ad stuff.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 6 Aug 2015 01:24:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef0bdbc0da8cb364d254ebb5cf4053f58541ba10
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ef0bdbc by Guy Harris (guy@xxxxxxxxxxxx):

    Cleanup a bunch of 802.11ad stuff.
    
    Make all the multi-byte fields, except for OUIs, little-endian -
    including fields that contain bitfields.  Make the bits in the bitfields
    little-endian as well.
    
    For the "number of taps" bitfields, interpret the values.
    
    Fix a typo ("pseduo" -> "pseudo").
    
    The length of an OCT MMPDU is 16 bits, not 8 bits, and it's not a text
    string, it's an octet string.
    
    The Beacon Interval Control is 48 bits, not 64 bits.
    
    Handle the beam refinement UI as a 2-byte field that overlaps with a
    4-byte field - *none* of the bitfields align on nice 8-bit boundaries,
    so that's the best we can do.
    
    Bug: 11419
    Change-Id: Ib00ad030ecb33cf676bec23c05b15a4211c75c07
    Reviewed-on: https://code.wireshark.org/review/9886
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  dc09d18   Output xhtml guides everywhere.
    adds  ef0bdbc   Cleanup a bunch of 802.11ad stuff.


Summary of changes:
 epan/dissectors/packet-ieee80211.c |  400 +++++++++++++++++++-----------------
 1 file changed, 211 insertions(+), 189 deletions(-)