Wireshark-commits: [Wireshark-commits] master 3413ddf: EPL: Fix Dead Store (Dead assignement/Dead i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 4 Aug 2015 15:33:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3413ddf6cb3bf033bc4b675b02770f48f5aa036d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3413ddf by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    EPL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    
    Change-Id: Id8fac193a2f3521986c0f91df84950ff581d4b6b
    Reviewed-on: https://code.wireshark.org/review/9790
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  992c892   MIB/OID Fix assertion in proto.c tmp_fld_check_assert(). It seems like oid_data->name may get freed so do a g_strdup() as it's done for hf.hfinfo.abbrev.
    adds  3413ddf   EPL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang


Summary of changes:
 epan/dissectors/packet-epl.c |   36 ++++++++++++++++--------------------
 1 file changed, 16 insertions(+), 20 deletions(-)