Wireshark-commits: [Wireshark-commits] master 78ca0af: HTTP2: remove weak part of the heuristic
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 2 Aug 2015 17:46:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=78ca0af62f97b75f834e3dbf1c51cb4fa1b9cc18
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

78ca0af by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    HTTP2: remove weak part of the heuristic
    
    It is so fragile that it triggers too many false positives and it was not
    activated by default prior to g21e5a95.
    If required, a user can still use 'Decode As' functionality.
    
    Change-Id: I0236609665c57c6f3961cb9596c47b54da777641
    Reviewed-on: https://code.wireshark.org/review/9842
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  d12283b   proto.c: exclude hf_text_only from proto_registrar_is_protocol()
    adds  78ca0af   HTTP2: remove weak part of the heuristic


Summary of changes:
 epan/dissectors/packet-http2.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)