Wireshark-commits: [Wireshark-commits] master 86a8b9c: MS-WSP: fix some Coverity warnings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Aug 2015 16:50:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=86a8b9c4b2e1679cf6bf9754d9afe71e412a18f8
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

86a8b9c by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    MS-WSP: fix some Coverity warnings
    
    - prevent some NULL pointer deference pointer
    - remove DISSECTOR_ASSERT calls: it should be used only for dissector bugs
    - replace g_slist_next macro calls as the NULL pointer checks are already performed in the for loop
    
    Change-Id: If4efd5bb055c7806107ec9646e9864c7e345246d
    Reviewed-on: https://code.wireshark.org/review/9843
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  f8cac8e   PNRP: add support for message reassembly
    adds  86a8b9c   MS-WSP: fix some Coverity warnings


Summary of changes:
 epan/dissectors/packet-mswsp.c |   13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)