Wireshark-commits: [Wireshark-commits] master d8d3c52: Use an ellipsis character instead of three d
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 31 Jul 2015 18:55:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d8d3c52f1e5836eddb32e46175aa399564c8ab36 Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: d8d3c52 by Gerald Combs (gerald@xxxxxxxxxxxxx): Use an ellipsis character instead of three dots. The OS X Human Interface Guidelines at https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/TerminologyWording.html#//apple_ref/doc/uid/20000957-CH15-SW3 says: "Be sure to create the ellipsis character using the key combination Option-; (Option-semicolon). This ensures that an assistive app can provide the correct interpretation of the character to a disabled user. If you use three period characters to simulate an ellipsis, many assistive apps will be unable to make sense of them. Also, three period characters and an ellipsis don't look the same because the periods are spaced differently than the points of an ellipsis." The Windows desktop applications guidelines has a section on ellipses: https://msdn.microsoft.com/en-us/library/windows/desktop/dn742478.aspx but doesn't specify the a single glyph vs three dots. The GNOME HIG at https://developer.gnome.org/hig/stable/typography.html.en says "Take Advantage of Unicode" then specifically says to use U+2026 HORIZONTAL ELLIPSIS. Remove the ellipsis from "Find Next" and "Find Previous". Neither requires user interaction. Change-Id: I0e6c28bb8b3a84b242731e2ca96f1a6f6f42c303 Reviewed-on: https://code.wireshark.org/review/9833 Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx> Actions performed: from c768087 MSWSP: Fix clang warnings and handle gracefully needed missing messages adds d8d3c52 Use an ellipsis character instead of three dots. Summary of changes: ui/qt/about_dialog.cpp | 9 +-- ui/qt/address_editor_frame.ui | 2 +- ui/qt/capture_interfaces_dialog.ui | 8 +-- ui/qt/conversation_dialog.cpp | 4 +- ui/qt/expert_info_dialog.ui | 2 +- ui/qt/extcap_argument_file.cpp | 5 +- ui/qt/follow_stream_dialog.cpp | 2 +- ui/qt/import_text_dialog.ui | 2 +- ui/qt/io_graph_dialog.cpp | 2 +- ui/qt/lbm_uimflow_dialog.cpp | 2 +- ui/qt/main_status_bar.cpp | 6 +- ui/qt/main_window.cpp | 4 +- ui/qt/main_window.ui | 100 +++++++++++++++--------------- ui/qt/main_window_preferences_frame.ui | 2 +- ui/qt/main_window_slots.cpp | 2 +- ui/qt/manage_interfaces_dialog.cpp | 3 +- ui/qt/module_preferences_scroll_area.cpp | 6 +- ui/qt/preference_editor_frame.ui | 2 +- ui/qt/print_dialog.cpp | 6 +- ui/qt/rtp_stream_dialog.cpp | 2 +- ui/qt/sequence_dialog.cpp | 2 +- ui/qt/tap_parameter_dialog.cpp | 2 +- ui/qt/tap_parameter_dialog.ui | 2 +- ui/qt/tcp_stream_dialog.cpp | 2 +- ui/qt/time_shift_dialog.ui | 2 +- 25 files changed, 95 insertions(+), 86 deletions(-)
- Prev by Date: [Wireshark-commits] master c768087: MSWSP: Fix clang warnings and handle gracefully needed missing messages
- Next by Date: [Wireshark-commits] master 787fa27: Remove spaces.
- Previous by thread: [Wireshark-commits] master c768087: MSWSP: Fix clang warnings and handle gracefully needed missing messages
- Next by thread: [Wireshark-commits] master 787fa27: Remove spaces.
- Index(es):