Wireshark-commits: [Wireshark-commits] master-1.12 1639c74: tcp: only reset dupACK counter when ACk
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 31 Jul 2015 02:07:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1639c74061ebf4636e0091eb808f9c656055bc1e
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

1639c74 by Evan Huus (eapache@xxxxxxxxx):

    tcp: only reset dupACK counter when ACk# changes
    
    Otherwise things like window changes will reset the dup-ack counter incorrectly
    and confusingly.
    
    Bug: 11397
    Change-Id: I80b63cf989a952547bec48562a92078c8ab29081
    Reviewed-on: https://code.wireshark.org/review/9802
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit 2c798305853524083f49cd4fb03db84533c6d750)
    Reviewed-on: https://code.wireshark.org/review/9811
    

Actions performed:

    from  cd013e8   [ieee80211]  Don't call expert_...() under 'if (tree)'
    adds  1639c74   tcp: only reset dupACK counter when ACk# changes


Summary of changes:
 epan/dissectors/packet-tcp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)