Wireshark · Wireshark-commits: [Wireshark-commits] master 01bc31c: Fixup packet list context menu behavior.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01bc31cded7290433704e9ef98a90e338c3ea28b
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

01bc31c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Fixup packet list context menu behavior.
    
    Add logic to setMenusForSelectedPacket for setting the enabled states
    for the "Apply As" and "Prepare A" actions. Update the PacketList
    context menu code to fill in the right filter at the right time.
    
    Exit out of setMenusForSelectedTreeRow if the packet list has focus so
    that we don't clobber the enabled states of various actions.
    
    Take the "Apply As" and "Prepare A" context menu titles from their main
    window counterparts. Remove actionApply_as_Filter and
    actionPrepare_a_Filter.
    
    Remove completed to-do items.
    
    Change-Id: I8f6f538bb7786d8df02a999f3b449dfde640e847
    Reviewed-on: https://code.wireshark.org/review/9810
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  2c79830   tcp: only reset dupACK counter when ACk# changes
    adds  01bc31c   Fixup packet list context menu behavior.


Summary of changes:
 ui/qt/main_window.cpp       |    2 ++
 ui/qt/main_window.ui        |   24 ++++++---------------
 ui/qt/main_window_slots.cpp |   50 ++++++++++++++++++++++---------------------
 ui/qt/packet_list.cpp       |   18 +++++++++-------
 ui/qt/packet_list.h         |    2 +-
 ui/qt/proto_tree.cpp        |   10 ++++-----
 6 files changed, 51 insertions(+), 55 deletions(-)