Wireshark-commits: [Wireshark-commits] master c425334: MSWSP: Initial implementation of MS-WSP (win
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Jul 2015 12:58:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c425334394ea22b55a48b282a77553584ede4efc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c425334 by Gregor Beck (gbeck@xxxxxxxxx):

    MSWSP: Initial implementation of MS-WSP (windows search protocol) dissector
    
    This changeset is a forward port of Gregors ms-wsp branch from his
    repo http://repo.or.cz/w/wireshark-wip.git. Most of the messages of
    the MS-WSP protocol are implemented here and as such consists of the
    majority of the changes for the dissector.
    
    In addition to the forward porting Gregors work I added some extra bits
    1) cater for SMB2 Read Response and Write Request msgs that can also
       contain MSWSP messages
    2) update property specifications with info extracted from MS-WSP protocol
       doc
    3) store some basic data about previously seen messages that are needed
       for dissecting CPMGetRows request
    4) expand/update dissect_CPMSetBindings & parse_CTableColumn routines
    5) parse and store CTableColumn & CPMSetBindingsIn structures in conversation
       related data for use later.
    6) fully dissect/parse SeekDesciption of CPMGetRowsOut
    7) dissect CPMGetRows out message specifically the Rows & Columns
    8) flesh out the boolean properties of uBooleanOptions field
    9) flesh out various other dissectors:
    	CPMRatioFinished
    	CPMRestartPosition
    	CPMCompareBmkIn/CPMCompareBmkOut
    	CPMGetApproximatePosition
    	CPMGetSendNotifyOut
    	FindIndicesIn/Out
    	FetchValue
    
    Bug: 11321
    Change-Id: I68b5c2f3e63874c1dbb271feab89b2b8aa65ac39
    Signed-off-by: Noel Power <noel.power@xxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/9440
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  23ca456   MAC LTE: fix dump of last SDU
    adds  c425334   MSWSP: Initial implementation of MS-WSP (windows search protocol) dissector


Summary of changes:
 docbook/release-notes.asciidoc    |    1 +
 epan/CMakeLists.txt               |    1 +
 epan/dissectors/Makefile.common   |    1 +
 epan/dissectors/packet-mswsp.c    | 8211 +++++++++++++++++++++++++++++++++++++
 epan/dissectors/packet-smb-pipe.c |   16 +-
 epan/dissectors/packet-smb-pipe.h |    2 +-
 epan/dissectors/packet-smb.c      |   11 +-
 epan/dissectors/packet-smb2.c     |   47 +-
 epan/dissectors/packet-smb2.h     |    2 +-
 9 files changed, 8256 insertions(+), 36 deletions(-)
 create mode 100644 epan/dissectors/packet-mswsp.c