Wireshark-commits: [Wireshark-commits] master 7be155e: Try deleting WiresharkDialog when we close i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 24 Jul 2015 20:03:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7be155ee1ec61166bdf1a525902c05b378c75b66
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7be155e by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Try deleting WiresharkDialog when we close it.
    
    QDialog::accept and ::reject hide the dialog but don't delete it. In the
    case of WiresharkDialog and its subclasses we might leak memory or leave
    files open. Call deleteLater when we close the dialog.
    
    Change-Id: Ie0b848a7deeeee4667925b0d886e498f13a86bfc
    Reviewed-on: https://code.wireshark.org/review/9781
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d24614c   MAC LTE: fix dissection when only header is captured but full PDU length is reported
    adds  7be155e   Try deleting WiresharkDialog when we close it.


Summary of changes:
 ui/qt/rtp_analysis_dialog.cpp |    8 --------
 ui/qt/rtp_analysis_dialog.h   |    3 ---
 ui/qt/wireshark_dialog.cpp    |   16 ++++++++++++++++
 ui/qt/wireshark_dialog.h      |    3 +++
 4 files changed, 19 insertions(+), 11 deletions(-)