Wireshark-commits: [Wireshark-commits] master c5bda79: openSAFETY: Disable heur dissector & scm bug
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 23 Jul 2015 15:57:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5bda791f2c5a9dc4fa5db08483a247c9fafaeee
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c5bda79 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    openSAFETY: Disable heur dissector & scm bugfix
    
     - Bugfix for the SCM UDID, where the expert info was generated
       even if not necessary, and a SCM UDID consisting of zeroes was
       considered to be valid
    
     - Using the new method for enabling/disabling heuristic dissectors,
       this patch reworks the SIII dissection to perform exactly the
       same as the EPL dissection (which is the expected behavior)
    
    Change-Id: Ide559c3e104b77818cef642b34e0076a7c5bd13d
    Reviewed-on: https://code.wireshark.org/review/9735
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b191f7e   epl: Fix epl write multiple parameter by index
    adds  c5bda79   openSAFETY: Disable heur dissector & scm bugfix


Summary of changes:
 epan/dissectors/packet-opensafety.c |  135 ++++++++++++++++-------------------
 1 file changed, 63 insertions(+), 72 deletions(-)