Wireshark-commits: [Wireshark-commits] master 32d9a1d: Ensure to copy the (un)resolved (source|dest
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Jul 2015 07:06:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32d9a1d714d5d253428a5c3d5450e1d3316a9f16
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

32d9a1d by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Ensure to copy the (un)resolved (source|destination) address columns before freeing epan memory
    
    Otherwise addresses like AT_STRINGZ using pinfo->pool are using an already freed memory block
    
    Bug: 11387
    Change-Id: I615d6bf202d57a949e75ba06a39f8d3e464def2f
    Reviewed-on: https://code.wireshark.org/review/9744
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  83dc308   PCLI: Expand protocol support
    adds  32d9a1d   Ensure to copy the (un)resolved (source|destination) address columns before freeing epan memory


Summary of changes:
 ui/gtk/packet_list_store.c   |   36 ++++++++++++++++++------------------
 ui/qt/packet_list_record.cpp |   34 +++++++++++++++++-----------------
 2 files changed, 35 insertions(+), 35 deletions(-)