Wireshark-commits: [Wireshark-commits] master 63edb99: Add general a busy progress indicator.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Jul 2015 19:48:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63edb9904fafb21ead6b69a712a6726159319d22
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

63edb99 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add general a busy progress indicator.
    
    Rename CaptureFileProgressFrame to ProgressFrame. It's not limited to
    capture files. Add "busy" routines there and in MainStatusBar. Show a
    busy indicator while sorting columns.
    
    Use toByteArray().constData instead of .data. I'm not sure if it matters
    in our case but it's more correct.
    
    Change-Id: Ibe35fee9b9dd3fabb5ff8ddcc21f6bf59dec4af6
    Reviewed-on: https://code.wireshark.org/review/9720
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  eb1ccbd   Protect dissector_get_(default_)string_handle() against NULL input string
    adds  63edb99   Add general a busy progress indicator.


Summary of changes:
 ui/qt/CMakeLists.txt                               |    6 +-
 ui/qt/Makefile.am                                  |    4 +-
 ui/qt/Makefile.common                              |    8 +-
 ui/qt/Wireshark.pro                                |    6 +-
 ui/qt/main_status_bar.cpp                          |   19 +++-
 ui/qt/main_status_bar.h                            |    6 +-
 ui/qt/main_window.cpp                              |    4 +
 ui/qt/packet_list_model.cpp                        |   29 ++++--
 ui/qt/packet_list_model.h                          |    2 +
 ui/qt/packet_list_record.cpp                       |    1 -
 ..._file_progress_frame.cpp => progress_frame.cpp} |  110 +++++++++++++-------
 ...ture_file_progress_frame.h => progress_frame.h} |   36 ++++---
 ...re_file_progress_frame.ui => progress_frame.ui} |    4 +-
 ui/qt/wireshark_de.ts                              |    2 +-
 ui/qt/wireshark_en.ts                              |    2 +-
 ui/qt/wireshark_fr.ts                              |    2 +-
 ui/qt/wireshark_it.ts                              |    2 +-
 ui/qt/wireshark_ja_JP.ts                           |    2 +-
 ui/qt/wireshark_pl.ts                              |    2 +-
 ui/qt/wireshark_zh_CN.ts                           |    2 +-
 20 files changed, 166 insertions(+), 83 deletions(-)
 rename ui/qt/{capture_file_progress_frame.cpp => progress_frame.cpp} (78%)
 rename ui/qt/{capture_file_progress_frame.h => progress_frame.h} (70%)
 rename ui/qt/{capture_file_progress_frame.ui => progress_frame.ui} (93%)