Wireshark-commits: [Wireshark-commits] master 170def9: Fix escaping of strings in UATs.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Jul 2015 17:03:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=170def95113b0cc21fdfc7dc1182fd01b4910832
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

170def9 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix escaping of strings in UATs.
    
    Not only must characters that aren't printable ASCII characters be
    escaped, backslashes must be escaped (as backslash is an escape
    introducer) and double-quotes must be escaped (as double-quotes
    encapsulate strings).
    
    When constructing a string to hand to uat_load_str(), escape pathnames,
    as they are likely to contain backslashes on Windows, could contain
    backslashes on UN*X, and could contain quotes on UN*X and possibly
    Windows.  (Arguably, we should escape all the string arguments
    
    Bug: 11372
    Change-Id: I594840327fa41895130903c3c612ba97d6c29df3
    Reviewed-on: https://code.wireshark.org/review/9716
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  09ae055   GTPv2: always set direction before dissecting PCO IE
    adds  170def9   Fix escaping of strings in UATs.


Summary of changes:
 epan/dissectors/packet-dtls.c |    4 +++-
 epan/dissectors/packet-ssl.c  |    4 +++-
 epan/uat.c                    |    6 +++---
 3 files changed, 9 insertions(+), 5 deletions(-)