Wireshark-commits: [Wireshark-commits] master 21e5a95: Remove all preferences related to enabling/d
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Jul 2015 17:12:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21e5a950ade6a20260b63b5f5c055c52ac07b599 Submitter: Michael Mann (mmann78@xxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: 21e5a95 by Michael Mann (mmann78@xxxxxxxxxxxx): Remove all preferences related to enabling/disabling heuristic dissectors. The preferences are still supported for backwards compatibility, but the heuristic_protos file has final say on the "preference" to enable/disable a heuristic dissector. Also add parameter to heur_dissector_add() for the "default" enable/disable of a heuristic dissector. With this parameter, a few more (presumably weak) heuristic dissectors have been "registered" but of course default to being disabled. Change-Id: I51bebb2146ef3fbb8418d4f5c7f2cb2b58003a22 Reviewed-on: https://code.wireshark.org/review/9610 Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx> Reviewed-by: Roland Knall <rknall@xxxxxxxxx> Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx> Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx> Actions performed: from 5bd6c4a STUN: Add missing error codes adds 21e5a95 Remove all preferences related to enabling/disabling heuristic dissectors. Summary of changes: asn1/atn-cm/packet-atn-cm-template.c | 2 +- asn1/atn-cpdlc/packet-atn-cpdlc-template.c | 2 +- asn1/atn-ulcs/packet-atn-ulcs-template.c | 2 +- asn1/credssp/packet-credssp-template.c | 2 +- asn1/mms/packet-mms-template.c | 4 +- asn1/mpeg-audio/packet-mpeg-audio-template.c | 2 +- asn1/mpeg-pes/packet-mpeg-pes-template.c | 2 +- asn1/ranap/packet-ranap-template.c | 9 ++-- asn1/rnsap/packet-rnsap-template.c | 7 +-- asn1/t124/packet-t124-template.c | 2 +- asn1/t125/packet-t125-template.c | 4 +- epan/disabled_protos.c | 3 -- epan/dissectors/file-btsnoop.c | 2 +- epan/dissectors/file-elf.c | 2 +- epan/dissectors/file-gif.c | 4 +- epan/dissectors/file-jpeg.c | 4 +- epan/dissectors/file-png.c | 4 +- epan/dissectors/packet-3com-njack.c | 4 +- epan/dissectors/packet-6lowpan.c | 2 +- epan/dissectors/packet-acn.c | 11 +--- epan/dissectors/packet-adwin-config.c | 4 +- epan/dissectors/packet-aeron.c | 2 +- epan/dissectors/packet-applemidi.c | 2 +- epan/dissectors/packet-ar_drone.c | 2 +- epan/dissectors/packet-artnet.c | 2 +- epan/dissectors/packet-at.c | 4 +- epan/dissectors/packet-atn-cm.c | 2 +- epan/dissectors/packet-atn-cpdlc.c | 2 +- epan/dissectors/packet-atn-ulcs.c | 2 +- epan/dissectors/packet-bfcp.c | 17 ++---- epan/dissectors/packet-bitcoin.c | 2 +- epan/dissectors/packet-bittorrent.c | 2 +- epan/dissectors/packet-bssap.c | 4 +- epan/dissectors/packet-bt-dht.c | 10 +--- epan/dissectors/packet-bt-utp.c | 11 ++-- epan/dissectors/packet-carp.c | 2 +- epan/dissectors/packet-cattp.c | 13 +---- epan/dissectors/packet-ceph.c | 2 +- epan/dissectors/packet-cigi.c | 2 +- epan/dissectors/packet-cimd.c | 2 +- epan/dissectors/packet-cip.c | 2 +- epan/dissectors/packet-cipsafety.c | 2 +- epan/dissectors/packet-classicstun.c | 4 +- epan/dissectors/packet-clique-rm.c | 2 +- epan/dissectors/packet-credssp.c | 2 +- epan/dissectors/packet-ctdb.c | 2 +- epan/dissectors/packet-dcc.c | 2 +- epan/dissectors/packet-dcerpc.c | 12 ++--- epan/dissectors/packet-dcm.c | 19 ++----- epan/dissectors/packet-dcp-etsi.c | 2 +- epan/dissectors/packet-dnp.c | 50 ++++++++++------- epan/dissectors/packet-dplay.c | 4 +- epan/dissectors/packet-drda.c | 2 +- epan/dissectors/packet-dtls.c | 2 +- epan/dissectors/packet-dvb-s2-bb.c | 8 +-- epan/dissectors/packet-e100.c | 2 +- epan/dissectors/packet-etch.c | 2 +- epan/dissectors/packet-fcip.c | 2 +- epan/dissectors/packet-fcoib.c | 2 +- epan/dissectors/packet-fix.c | 2 +- epan/dissectors/packet-fmtp.c | 2 +- epan/dissectors/packet-giop.c | 4 +- epan/dissectors/packet-gmhdr.c | 4 +- epan/dissectors/packet-gvsp.c | 10 +--- epan/dissectors/packet-h1.c | 6 +-- epan/dissectors/packet-hdcp2.c | 10 +--- epan/dissectors/packet-hislip.c | 13 ++--- epan/dissectors/packet-http.c | 2 +- epan/dissectors/packet-http2.c | 17 ++---- epan/dissectors/packet-icep.c | 4 +- epan/dissectors/packet-ifcp.c | 2 +- epan/dissectors/packet-infiniband_sdp.c | 4 +- epan/dissectors/packet-interlink.c | 2 +- epan/dissectors/packet-ip.c | 2 +- epan/dissectors/packet-ipsec-tcp.c | 2 +- epan/dissectors/packet-iscsi.c | 2 +- epan/dissectors/packet-iser.c | 4 +- epan/dissectors/packet-iwarp-mpa.c | 2 +- epan/dissectors/packet-ixiatrailer.c | 2 +- epan/dissectors/packet-json.c | 4 +- epan/dissectors/packet-jxta.c | 62 ++++----------------- epan/dissectors/packet-knxnetip.c | 4 +- epan/dissectors/packet-lanforge.c | 4 +- epan/dissectors/packet-lapd.c | 2 +- epan/dissectors/packet-lbmpdmtcp.c | 2 +- epan/dissectors/packet-lbmr.c | 2 +- epan/dissectors/packet-lbtrm.c | 2 +- epan/dissectors/packet-lbtru.c | 2 +- epan/dissectors/packet-lbttcp.c | 2 +- epan/dissectors/packet-lwm.c | 2 +- epan/dissectors/packet-mac-lte.c | 20 +------ epan/dissectors/packet-mbim.c | 9 +--- epan/dissectors/packet-mim.c | 18 +------ epan/dissectors/packet-miop.c | 2 +- epan/dissectors/packet-mms.c | 4 +- ... 98 lines suppressed ...
- Prev by Date: [Wireshark-commits] master 5bd6c4a: STUN: Add missing error codes
- Next by Date: [Wireshark-commits] master 38c0506: WCCP - remove global variable used to store address information for computation later.
- Previous by thread: [Wireshark-commits] master 5bd6c4a: STUN: Add missing error codes
- Next by thread: [Wireshark-commits] master 38c0506: WCCP - remove global variable used to store address information for computation later.
- Index(es):