Wireshark-commits: [Wireshark-commits] master 3faec79: Qt/Bluetooth: Add HCI Summary dialogue
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Jul 2015 13:54:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3faec795e9c5b5f153f66960c11673c2f53e4243
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3faec79 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Qt/Bluetooth: Add HCI Summary dialogue
    
    HCI Summary dialogue collect HCI Opcodes, HCI Events, Hardware Errors,
    Statuses and Reasons. Also show occurrence of them. The top level item
    is group of items (by OGF or types), the second level item is in real
    command, event, hardware error, status or reason. The third level items
    are direct link to packet that contains second level item type.
    
    Change-Id: I6b6bd02533c4605a2dd2c1f5dfee46f72a0f3fdc
    Reviewed-on: https://code.wireshark.org/review/9676
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    

Actions performed:

    from  6514dec   Add preference for disabling 'packet size limited during capture' message in Info column.
    adds  3faec79   Qt/Bluetooth: Add HCI Summary dialogue


Summary of changes:
 docbook/release-notes.asciidoc                     |    1 +
 epan/dissectors/packet-bluetooth.c                 |    2 +
 epan/dissectors/packet-bluetooth.h                 |   29 +
 epan/dissectors/packet-bthci_cmd.c                 |   33 +-
 epan/dissectors/packet-bthci_evt.c                 |  414 +++++++++--
 epan/dissectors/packet-bthci_vendor.c              |   69 +-
 ui/qt/CMakeLists.txt                               |    3 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/Makefile.common                              |    4 +
 ui/qt/Wireshark.pro                                |    3 +
 ui/qt/bluetooth_hci_summary_dialog.cpp             |  727 ++++++++++++++++++++
 ...ces_dialog.h => bluetooth_hci_summary_dialog.h} |   45 +-
 ui/qt/bluetooth_hci_summary_dialog.ui              |  661 ++++++++++++++++++
 ui/qt/main_window.h                                |    1 +
 ui/qt/main_window.ui                               |    6 +
 ui/qt/main_window_slots.cpp                        |   11 +
 16 files changed, 1939 insertions(+), 72 deletions(-)
 create mode 100644 ui/qt/bluetooth_hci_summary_dialog.cpp
 copy ui/qt/{bluetooth_devices_dialog.h => bluetooth_hci_summary_dialog.h} (62%)
 create mode 100644 ui/qt/bluetooth_hci_summary_dialog.ui