Wireshark-commits: [Wireshark-commits] master 255d53d: Draw packet colors in the packet list scroll
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Jul 2015 22:57:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=255d53dfc11fa49eadd30fefe3ed5950b03e6659
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

255d53d by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Draw packet colors in the packet list scrollbar.
    
    Inspired by (but not as fancy as) Packet Fence, an enhancement written
    for Ethereal a loooong time ago by Martin Visser:
    
    https://www.wireshark.org/lists/ethereal-dev/200011/msg00122.html
    
    Several text editors call this a "minimap".
    
    Color each scrollbar raster line to match the color of up to 7 packets.
    Note in the comments why this number was chosen.
    
    If we have any flagged frames (marked, ignored, time ref) indicate them
    on either side of the scrolbar.
    
    Handle HiDPI (retina) displays. This means that your window size depends
    on the height of your scrollbar *and* your monitor resolution.
    
    Qt's idea of the slider rect doesn't match up with the slider on OS X.
    This might be local to my build -- I can replicate it Qt Creator.
    
    Change-Id: Ia089d2d766ce37bab11e22d1a5721b4908935304
    Reviewed-on: https://code.wireshark.org/review/8982
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  3e059c9   SMB2: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  255d53d   Draw packet colors in the packet list scrollbar.


Summary of changes:
 ui/qt/CMakeLists.txt                              |    2 +
 ui/qt/Makefile.common                             |    3 +
 ui/qt/Wireshark.pro                               |    2 +
 ui/qt/color_utils.cpp                             |    2 +-
 ui/qt/color_utils.h                               |    2 +-
 ui/qt/overlay_scroll_bar.cpp                      |  158 ++++++++++++++
 ui/qt/{accordion_frame.h => overlay_scroll_bar.h} |   38 ++--
 ui/qt/packet_list.cpp                             |  232 ++++++++++++++++++++-
 ui/qt/packet_list.h                               |   15 +-
 ui/qt/packet_list_model.cpp                       |   18 +-
 ui/qt/packet_list_model.h                         |    1 +
 ui/qt/packet_list_record.h                        |    1 +
 12 files changed, 438 insertions(+), 36 deletions(-)
 create mode 100644 ui/qt/overlay_scroll_bar.cpp
 copy ui/qt/{accordion_frame.h => overlay_scroll_bar.h} (64%)