Wireshark-commits: [Wireshark-commits] master 0d4f412: Get rid of _U_, which was (mis)used in some
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Jul 2015 21:03:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0d4f41201532134b84cbed2f00f05ffb5e4acbc1
Submitter: J?rg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0d4f412 by Joerg Mayer (jmayer@xxxxxxxxx):

    Get rid of _U_, which was (mis)used in some places:
    - It was used even though the variable actually *was* in use for
      some compile settings.
    - It's not the c++ way.
    
    2do: In case the definition of _U_ in Wireshark.pro is only used for
      the ui/qt directory, it should be removed to avoid further (ab)use.
    
    Change-Id: I22d6269a66d6ed558035aad3e6702c4a9c8af1fa
    Reviewed-on: https://code.wireshark.org/review/9665
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    

Actions performed:

    from  d23ff4f   Qt: remove unused parameters
    adds  0d4f412   Get rid of _U_, which was (mis)used in some places: - It was used even though the variable actually *was* in use for   some compile settings. - It's not the c++ way.


Summary of changes:
 ui/qt/main_status_bar.cpp           |   12 ++++++++----
 ui/qt/resolved_addresses_dialog.cpp |    2 +-
 2 files changed, 9 insertions(+), 5 deletions(-)