Wireshark-commits: [Wireshark-commits] master 41ed712: Qt: Frame flag updates.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Jul 2015 19:13:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=41ed7127a566a2758c8a5a0716ea0276f4182ed0
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

41ed712 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Frame flag updates.
    
    Move frame flag (mark, ignore, ref_time) member functions from
    PacketList to PacketListModel. They arguably belong there and we can
    emit dataChanged to signal updates.
    
    Rename some variables named "index" since they shadow a function name.
    
    Change-Id: I9a731a76e4e63e562b561c29d13915278d5a7dbb
    Reviewed-on: https://code.wireshark.org/review/9663
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  b1e0f43   One definition of the same typedef suffices.
    adds  41ed712   Qt: Frame flag updates.


Summary of changes:
 ui/qt/packet_list.cpp        |  122 +++++------------------------------------
 ui/qt/packet_list.h          |    3 -
 ui/qt/packet_list_model.cpp  |  125 ++++++++++++++++++++++++++++++++++++++----
 ui/qt/packet_list_model.h    |   12 +++-
 ui/qt/packet_list_record.cpp |    1 +
 5 files changed, 137 insertions(+), 126 deletions(-)