Wireshark-commits: [Wireshark-commits] master d2acb04: Add the RTP Stream Analysis dialog.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Jul 2015 00:30:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d2acb04b4cadd90bf09bdc4959e6bffb25dcfd38
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d2acb04 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add the RTP Stream Analysis dialog.
    
    Combine the GTK+ RTP Stream Analysis and RTP Graph Analysis dialogs into
    one. Yell at the user less. Disable the Analyze RTP Stream menu item if
    we don't have an RTP stream selected.
    
    There are a *lot* of moving parts in this dialog. I've tested with the
    few RTP captures I have but it's by no means complete.
    
    "To do" items are listed at the top of rtp_analysis.cpp.
    
    Change-Id: Id503977f069bebc46cc68bc749f0c9cbf4d37bf6
    Reviewed-on: https://code.wireshark.org/review/9650
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  2e215db   Revert "On OS X, add the Qt -Wl,-rpath hack in CMake, as we do with autotools."
    adds  d2acb04   Add the RTP Stream Analysis dialog.


Summary of changes:
 epan/proto.c                   |    5 +-
 epan/proto.h                   |    3 +-
 ui/gtk/main_menubar.c          |    2 +-
 ui/gtk/rtp_analysis.c          |   27 +-
 ui/qt/CMakeLists.txt           |    3 +
 ui/qt/Makefile.am              |    4 +
 ui/qt/Makefile.common          |    4 +
 ui/qt/Wireshark.pro            |    3 +
 ui/qt/color_utils.cpp          |   20 +-
 ui/qt/color_utils.h            |    1 +
 ui/qt/follow_stream_dialog.cpp |    2 +-
 ui/qt/io_graph_dialog.cpp      |   18 +-
 ui/qt/main_window.cpp          |    2 +-
 ui/qt/main_window.h            |    1 +
 ui/qt/main_window.ui           |    9 +
 ui/qt/main_window_slots.cpp    |   14 +-
 ui/qt/packet_list.cpp          |    2 +-
 ui/qt/qt_ui_utils.cpp          |    6 +-
 ui/qt/qt_ui_utils.h            |    3 +-
 ui/qt/rtp_analysis_dialog.cpp  | 1538 ++++++++++++++++++++++++++++++++++++++++
 ui/qt/rtp_analysis_dialog.h    |  156 ++++
 ui/qt/rtp_analysis_dialog.ui   |  346 +++++++++
 ui/qt/rtp_stream_dialog.cpp    |    5 +-
 ui/qt/syntax_line_edit.cpp     |    2 +-
 ui/rtp_analysis.h              |   10 +-
 ui/tap-rtp-common.c            |    2 +-
 ui/tap-rtp-common.h            |   36 +-
 ui/utf8_entities.h             |   19 +-
 28 files changed, 2183 insertions(+), 60 deletions(-)
 create mode 100644 ui/qt/rtp_analysis_dialog.cpp
 create mode 100644 ui/qt/rtp_analysis_dialog.h
 create mode 100644 ui/qt/rtp_analysis_dialog.ui