Wireshark-commits: [Wireshark-commits] master-1.12 4632823: Add a bounds check.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Jul 2015 18:53:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=46328232bc42d356a3d7c89901699d2220b9f420
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

4632823 by Guy Harris (guy@xxxxxxxxxxxx):

    Add a bounds check.
    
    AirPDcapStoreSa() was assuming that ctx->first_free_index would always
    be within the ctx->sa array; nothing guarantees that.  Fail if it's past
    the end of the array; that means there *are* no free indices.
    
    Change-Id: I73145ea3f3dda1b3800a41fa3a2b01ac344dcbfc
    Reviewed-on: https://code.wireshark.org/review/9634
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 4f1b8d74338ca2a6ded8498e9d87cbc3294454c0)
    Reviewed-on: https://code.wireshark.org/review/9635
    

Actions performed:

    from  8cb0d78   Lua: all protocol tree entries expand/contract together
    adds  4632823   Add a bounds check.


Summary of changes:
 epan/crypt/airpdcap.c |    4 ++++
 1 file changed, 4 insertions(+)