Wireshark-commits: [Wireshark-commits] master c305f08: PacketList column fixes.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c305f08921feb30f5411bc8f8e0b01ebf1cfbe2e
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
c305f08 by Gerald Combs (gerald@xxxxxxxxxxxxx):
PacketList column fixes.
Add a columnsChanged slot to PacketList and move the column update code
from redrawVisiblePackets there. Make sure we call
packet_list_model_->recreateVisibleRows, which should fix the behavior
described in bug 11324. Call columnsChanged when we, uh, change columns.
Add a sectionMoved slot to handle column reordering.
Don't rebuild the column list when we update the widgets in the column
preferences frame. Do enable and disable the "remove" button as needed.
Try to keep the user from removing all of the columns in both the packet
list and column preferences.
Left as an exercise for the reader: The GTK+ UI also fails when you
remove all of the columns via the preferences:
packet_list.c:377:packet_list_sort_column: assertion failed: (col)
Bug: 11324
Change-Id: Id58cf98e42cbda9aa2fc370ea06b8bcc6098c8ca
Reviewed-on: https://code.wireshark.org/review/9591
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from 494457d Make OS X .app bundling work with Qt 5.5.
adds c305f08 PacketList column fixes.
Summary of changes:
ui/qt/column_preferences_frame.cpp | 32 ++++++++++-----
ui/qt/column_preferences_frame.h | 4 +-
ui/qt/main_window.cpp | 2 +-
ui/qt/main_window_slots.cpp | 2 +-
ui/qt/packet_list.cpp | 75 ++++++++++++++++++++++++++++++------
ui/qt/packet_list.h | 2 +
6 files changed, 92 insertions(+), 25 deletions(-)
