Wireshark-commits: [Wireshark-commits] master e478267: Lua: fix docs and default base for ProtoFiel
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 11 Jul 2015 18:05:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e47826734e9d3d6ca2c3589883ff62fce08e7339
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e478267 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Lua: fix docs and default base for ProtoField.framenum()
    
    The ProtoField.framenum() Lua function says to use base.DEC, HEX, etc.
    But it really can only allow base.NONE. Also, the code defaults
    to base.DEC if none was given, and then errors if it's a FT_FRAMENUM;
    instead the default base for FT_FRAMENUM should be base.NONE.
    
    Change-Id: I0ec867069c66dbb58399ac2db4652469bfb39152
    Reviewed-on: https://code.wireshark.org/review/9599
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  080c27f   simple_statistics_dialog(.h): fix parameter 'rtd_table/user_table' not found in the function declaration [-Wdocumentation]
    adds  e478267   Lua: fix docs and default base for ProtoField.framenum()


Summary of changes:
 epan/wslua/wslua_proto.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)