Wireshark-commits: [Wireshark-commits] master 2a5a560: VXLAN: Add Group Based Policy dissector
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 9 Jul 2015 20:28:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a5a560a64e73832c6a91b4a3772ddbda0e7d5fb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2a5a560 by Amine Kherbouche (amine.kherbouche@xxxxxxxxx):

    VXLAN: Add Group Based Policy dissector
    
    According to some advices from my last commit,i made some changes, and i
    use proto_tree_add_bitmask for bits field.
    
    Editing VXLAN dissector for supporting GBP extension described in the
    following draft link :
    https://tools.ietf.org/html/draft-smith-vxlan-group-policy-00
    
    This pach works fine with "old" version of VXLAN (no GBP support)
    
    The flags are now extended to 16 bits to support GBP extension, Group
    Policy Id is on 16 bits, VNI always on 24 bits and remaining bits are reserved.
    The following bits are defined in addition to the existing VXLAN fields:
    	bit 0 : "G" Group Based Policy Extension bit
    	bit 9 : "D" Don't Learn bit
    	bit 12 : "A" Policy Applied bit
    	the remaining bits are reserved
    
    Bug: 11348
    Change-Id: I425ed63cf76f134eb3d1680a1753ed31f252dfa8
    Signed-off-by: Amine Kherbouche <amine.kherbouche@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/9537
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fdd07c4   Make sure we uncheck the "Find Packet" action.
    adds  2a5a560   VXLAN: Add Group Based Policy dissector


Summary of changes:
 epan/dissectors/packet-vxlan.c |  101 ++++++++++++++++------------------------
 epan/dissectors/packet-wccp.c  |    2 +-
 epan/tfs.c                     |    1 +
 epan/tfs.h                     |    1 +
 4 files changed, 44 insertions(+), 61 deletions(-)