Wireshark-commits: [Wireshark-commits] master e0deadc: opcua dissector: fix display of service type
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 8 Jul 2015 18:33:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0deadcbc79dcee74eef693ba47485fccfc15446
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e0deadc by Hannes Mezger (hannes.mezger@xxxxxxxxxxx):

    opcua dissector: fix display of service type in packet column
    
    The loop was iterating using g_NumServices, which is the number of entries in g_arParserTable and not the number of entries in g_requesttypes. Instead now we use val_to_str which can in addition display the ServiceId instead if not found in the table.
    
    Change-Id: If15ee5c460e07c4687464805935b92c913392011
    Reviewed-on: https://code.wireshark.org/review/9459
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  4eca268   Add SimpleStatisticsDialog.
    adds  e0deadc   opcua dissector: fix display of service type in packet column


Summary of changes:
 plugins/opcua/opcua.c |   23 ++++++++---------------
 1 file changed, 8 insertions(+), 15 deletions(-)