Wireshark · Wireshark-commits: [Wireshark-commits] master-1.10 b0f2f58: MySQL: dissector adds packet content to INFO column without

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b0f2f58491f5e1790d5c0a66d13ea30b8e0aba47
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

b0f2f58 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    MySQL: dissector adds packet content to INFO column without scrubbing it
    
    Make the MYSQL protocol dissector scrub the strings from the packet content by
    putting it through format_text() to remove/replace CR, LF, TAB, etc. The
    fields affected are: query string, greeting version string, login username,
    and login schema.
    
    Bug: 11344
    Change-Id: Ibddbcce3e6e98bc3866cab9eb76e9762e4d19138
    Reviewed-on: https://code.wireshark.org/review/9538
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    (cherry picked from commit 4f1a81871add662e6cafb0b17a67eb0a600d21c4)
    Reviewed-on: https://code.wireshark.org/review/9542
    Tested-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    (cherry picked from commit 8354b0e80885e2080e5d514e8562bc2d1d773d9e)
    Reviewed-on: https://code.wireshark.org/review/9545
    

Actions performed:

    from  c10155f   If we don't know whether STBC is being used, we don't know NSTS.
    adds  b0f2f58   MySQL: dissector adds packet content to INFO column without scrubbing it


Summary of changes:
 epan/dissectors/packet-mysql.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)