Wireshark-commits: [Wireshark-commits] master-1.12 8354b0e8: MySQL: dissector adds packet content t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Jul 2015 18:09:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8354b0e80885e2080e5d514e8562bc2d1d773d9e
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

8354b0e8 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    MySQL: dissector adds packet content to INFO column without scrubbing it
    
    Make the MYSQL protocol dissector scrub the strings from the packet content by
    putting it through format_text() to remove/replace CR, LF, TAB, etc. The
    fields affected are: query string, greeting version string, login username,
    and login schema.
    
    Bug: 11344
    Change-Id: Ibddbcce3e6e98bc3866cab9eb76e9762e4d19138
    Reviewed-on: https://code.wireshark.org/review/9538
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    (cherry picked from commit 4f1a81871add662e6cafb0b17a67eb0a600d21c4)
    Reviewed-on: https://code.wireshark.org/review/9542
    Tested-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  9d50c5e   Add identification of Windows 10 / Windows Server 2016
    adds  8354b0e8  MySQL: dissector adds packet content to INFO column without scrubbing it


Summary of changes:
 epan/dissectors/packet-mysql.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)