Wireshark-commits: [Wireshark-commits] master 21754f4: Starting to get rid of Q_UNUSED declarations
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21754f43e1e7139bcd3d673714c2a191681a63e9
Submitter: J?rg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
21754f4 by Joerg Mayer (jmayer@xxxxxxxxx):
Starting to get rid of Q_UNUSED declarations for unused function parameters.
The official C++ way is to leave out the variable name instead. This has the
advantage to be reliable: In one case a variable declared unused was later
used.
Change-Id: I1c96636f7fa7a621d1594d1e9cacaec75c561faa
Reviewed-on: https://code.wireshark.org/review/9532
Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
Actions performed:
from aca5f4e Revert "diameter: convert some GArrays to epan wmem_arrays"
adds 21754f4 Starting to get rid of Q_UNUSED declarations for unused function parameters. The official C++ way is to leave out the variable name instead. This has the advantage to be reliable: In one case a variable declared unused was later used.
Summary of changes:
ui/qt/packet_format_group_box.cpp | 6 ++----
ui/qt/packet_list.cpp | 7 ++-----
ui/qt/packet_range_group_box.cpp | 3 +--
ui/qt/preferences_dialog.cpp | 19 +++++--------------
ui/qt/print_dialog.cpp | 5 +----
ui/qt/profile_dialog.cpp | 4 +---
ui/qt/proto_tree.cpp | 4 +---
ui/qt/remote_capture_dialog.cpp | 5 +----
ui/qt/rtp_stream_dialog.cpp | 3 +--
ui/qt/sequence_diagram.cpp | 15 ++++-----------
ui/qt/sequence_dialog.cpp | 9 +++------
ui/qt/sparkline_delegate.cpp | 5 +----
ui/qt/splash_overlay.cpp | 8 ++------
ui/qt/tcp_stream_dialog.cpp | 7 ++-----
ui/qt/time_shift_dialog.cpp | 25 ++++++++-----------------
ui/qt/traffic_table_dialog.cpp | 3 +--
ui/qt/traffic_table_dialog.h | 2 +-
ui/qt/uat_dialog.cpp | 2 --
ui/qt/voip_calls_dialog.cpp | 8 ++------
19 files changed, 39 insertions(+), 101 deletions(-)
