Wireshark-commits: [Wireshark-commits] master 5999b97: MySQL: dissector adds packet content to INFO
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Jul 2015 01:00:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5999b9701343614508a7802fbd7048202973a2b7
Submitter: Hadriel Kaplan (hadrielk@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5999b97 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    MySQL: dissector adds packet content to INFO column without scrubbing it
    
    Make the MYSQL protocol dissector scrub the strings from the packet content by
    putting it through format_text() to remove/replace CR, LF, TAB, etc. The
    fields affected are: query string, greeting version string, login username,
    and login schema.
    
    Bug: 11344
    
    Change-Id: Ie1a593026c21720eecc77e7b3a7e63db11adf2a1
    Reviewed-on: https://code.wireshark.org/review/9530
    Petri-Dish: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    

Actions performed:

    from  8ebf735   Clean up a bunch of stuff.
    adds  5999b97   MySQL: dissector adds packet content to INFO column without scrubbing it


Summary of changes:
 epan/dissectors/packet-mysql.c |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)