Wireshark-commits: [Wireshark-commits] master 8ebf735: Clean up a bunch of stuff.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Jul 2015 23:46:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ebf735c90a2960aa4b9d6c04bab0516ca17e84f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8ebf735 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up a bunch of stuff.
    
    The command byte values aren't FPGA-specific - if they were, the code
    wouldn't have worked.  Provide #defines for the main ones and check for
    them, and use that to determine whether the packet is transmitted or
    received.
    
    Add a bunch of #defines, shuffle some defines to cluster related ones
    together and separate unrelated ones, get rid of duplicate #defines
    (where different FPGAs use the same value).
    
    Fix some typoes.
    
    Change-Id: Ic8adc589d7c36a4a91a81858de40c904743dd067
    Reviewed-on: https://code.wireshark.org/review/9529
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  886c2d0   Update a comment.
    adds  8ebf735   Clean up a bunch of stuff.


Summary of changes:
 wiretap/vwr.c |  256 +++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 157 insertions(+), 99 deletions(-)