Wireshark-commits: [Wireshark-commits] master ebae0c9: store tcp/udp port names in epan scope
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 4 Jul 2015 12:21:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ebae0c98f8556b9533cd1bb21c4bac548ab5e470
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ebae0c9 by Evan Huus (eapache@xxxxxxxxx):

    store tcp/udp port names in epan scope
    
    This causes them to be freed on shutdown, cleaning up ~800KB of "reachable"
    memory according to valgrind. The fact that we even need to construct these as
    value_strings is questionable IMHO, but that's a problem for a later date.
    
    Switch epan_scope to the BLOCK allocator now that we're using it for so much
    more, this gives a small but measurable increase in startup time.
    
    Change-Id: I187460b769e28da3c6629abac1d9196727ae7dde
    Reviewed-on: https://code.wireshark.org/review/9483
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  dd8311d   Lua: split init/cleanup routines
    adds  ebae0c9   store tcp/udp port names in epan scope


Summary of changes:
 epan/dissectors/packet-tcp.c |    2 +-
 epan/dissectors/packet-udp.c |    2 +-
 epan/wmem/wmem_scopes.c      |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)