Wireshark-commits: [Wireshark-commits] master fdb8502: Add ServiceResponseTimeDialog.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Jul 2015 23:09:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fdb85029fd9b22b221f7123905f1bad66c04ce91
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fdb8502 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add ServiceResponseTimeDialog.
    
    Add ServiceResponseTimeDialog as a subclass of TapParameterDialog,
    similar to StatsTreeDialog. Add initial plumbing for statistics menu
    items and command line invocation.
    
    Don't append "..." to menu item names. Don't add menu icons. In each
    case this avoids repetitive UI clutter.
    
    Change-Id: I463b95c93090160bb81d2e80b16aad389dc0bd6c
    Reviewed-on: https://code.wireshark.org/review/8864
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7fdc534   Convert BOOTP/DHCP tap stats to new "generic stat API".
    adds  fdb8502   Add ServiceResponseTimeDialog.


Summary of changes:
 doc/tshark.pod                                    |    6 +
 doc/wireshark.pod.template                        |   12 +
 epan/srt_table.h                                  |    7 +-
 epan/stat_groups.h                                |    4 +-
 epan/stat_tap_ui.h                                |    3 +-
 epan/stats_tree.c                                 |    3 +-
 epan/stats_tree.h                                 |    8 +
 epan/timestats.h                                  |   14 +-
 ui/CMakeLists.txt                                 |    1 +
 ui/Makefile.common                                |    2 +
 ui/gtk/service_response_time_table.c              |   32 +-
 ui/gtk/service_response_time_table.h              |    4 +-
 ui/qt/CMakeLists.txt                              |    3 +
 ui/qt/Makefile.common                             |    2 +
 ui/qt/Wireshark.pro                               |    3 +
 ui/qt/expert_info_dialog.cpp                      |    3 +-
 ui/qt/expert_info_dialog.h                        |    6 +-
 ui/qt/filter_action.cpp                           |   15 +-
 ui/qt/filter_action.h                             |    2 +-
 ui/qt/main_window.cpp                             |   27 ++
 ui/qt/main_window.h                               |   21 +-
 ui/qt/main_window.ui                              |   26 +-
 ui/qt/main_window_slots.cpp                       |   34 +-
 ui/qt/qt_ui_utils.cpp                             |    5 +
 ui/qt/qt_ui_utils.h                               |   10 +
 ui/qt/service_response_time_dialog.cpp            |  411 +++++++++++++++++++++
 ui/qt/service_response_time_dialog.h              |   88 +++++
 ui/qt/stats_tree_dialog.cpp                       |   24 +-
 ui/qt/stats_tree_dialog.h                         |    2 +-
 ui/qt/tap_parameter_dialog.cpp                    |  320 +++++++++++++++-
 ui/qt/tap_parameter_dialog.h                      |   30 +-
 ui/qt/traffic_table_dialog.cpp                    |    1 -
 ui/qt/wireshark_application.cpp                   |   26 ++
 ui/qt/wireshark_application.h                     |    7 +
 ui/qt/wireshark_dialog.h                          |    2 +-
 ui/{qt/about_dialog.h => service_response_time.c} |   33 +-
 wsutil/processes.h => ui/service_response_time.h  |   51 +--
 wireshark-qt.cpp                                  |   43 ++-
 38 files changed, 1147 insertions(+), 144 deletions(-)
 create mode 100644 ui/qt/service_response_time_dialog.cpp
 create mode 100644 ui/qt/service_response_time_dialog.h
 copy ui/{qt/about_dialog.h => service_response_time.c} (66%)
 copy wsutil/processes.h => ui/service_response_time.h (57%)