Wireshark-commits: [Wireshark-commits] master a8ff1e2: Create very basic "generic" stat tap API to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Jul 2015 23:08:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8ff1e2778b22ca55db752264eaf864d720ca8dc
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a8ff1e2 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Create very basic "generic" stat tap API to create a "GUI" independent table.
    
    A few sample tap/dissectors (ANSI/A, ANSI MAP) are also included to test the API.  The "GUI output" is a bit raw and could use some "prettying up", but all the basic hooks are there.
    
    Telephony "stat grouping" needs to be better alphabetized to properly populate menu (on GTK, probably Qt)
    
    Change-Id: I98514171f69c4ab3a304dccb26c71d629703c9ab
    Reviewed-on: https://code.wireshark.org/review/9110
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  09ea473   bootp: try to fix OSX builtbot
    adds  a8ff1e2   Create very basic "generic" stat tap API to create a "GUI" independent table.


Summary of changes:
 CMakeLists.txt                                     |    2 +-
 asn1/ansi_map/packet-ansi_map-template.c           |  116 ++++++
 epan/dissectors/packet-ansi_a.c                    |  163 ++++++++
 epan/dissectors/packet-ansi_map.c                  |  126 ++++++-
 epan/stat_tap_ui.c                                 |  155 ++++++++
 epan/stat_tap_ui.h                                 |   98 +++++
 tshark.c                                           |    1 +
 ui/cli/Makefile.common                             |    2 +-
 ui/cli/tap-ansi_astat.c                            |  182 ---------
 ui/cli/tap-simple_stattable.c                      |  170 +++++++++
 ui/cli/tshark-tap.h                                |    1 +
 ui/gtk/CMakeLists.txt                              |    3 +-
 ui/gtk/Makefile.common                             |    8 +-
 ui/gtk/ansi_a_stat.c                               |  382 -------------------
 ui/gtk/ansi_map_stat.c                             |  393 --------------------
 ui/gtk/bootp_stat.c                                |    3 +-
 ui/gtk/camel_counter.c                             |    7 +-
 ui/gtk/gui_stat_util.c                             |   12 +-
 ui/gtk/gui_stat_util.h                             |    3 -
 ui/gtk/h225_counter.c                              |    7 +-
 ui/gtk/mac_lte_stat_dlg.c                          |    3 +-
 ui/gtk/main.c                                      |    2 +
 ui/gtk/main_menubar.c                              |   10 -
 ui/gtk/response_time_delay_table.c                 |   38 +-
 ui/gtk/rlc_lte_stat_dlg.c                          |    3 +-
 ui/gtk/sctp_chunk_stat.c                           |   43 +--
 ui/gtk/service_response_time_table.c               |    1 +
 ui/gtk/simple_stattable.c                          |  298 +++++++++++++++
 .../gtk/simple_stattable.h                         |   28 +-
 ui/gtk/sip_stat.c                                  |    3 +-
 ui/gtk/stats_tree_stat.c                           |    1 +
 ui/gtk/tap_param_dlg.c                             |   10 +-
 ui/gtk/tap_param_dlg.h                             |    1 +
 ui/gtk/wsp_stat.c                                  |    3 +-
 34 files changed, 1224 insertions(+), 1054 deletions(-)
 delete mode 100644 ui/cli/tap-ansi_astat.c
 create mode 100644 ui/cli/tap-simple_stattable.c
 delete mode 100644 ui/gtk/ansi_a_stat.c
 delete mode 100644 ui/gtk/ansi_map_stat.c
 create mode 100644 ui/gtk/simple_stattable.c
 copy asn1/c1222/packet-c1222-template.h => ui/gtk/simple_stattable.h (64%)