Wireshark-commits: [Wireshark-commits] master df5a315: Fix address resolution for columns.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Jul 2015 02:21:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=df5a315048e9b318f7862901c1bd40fa2c08dad5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

df5a315 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix address resolution for columns.
    
    Have address_to_name() be a routine that takes an address and returns a
    string with a "sufficiently long" lifetime for use in columns, using the
    address type's addr_name_res_str routine for most address types, rather
    than having a too-small set of address types wired into it.  It replaces
    both the internal solve_address_to_name() routine and get_addr_name(),
    and can, for example, handle the special WLAN address types rather than
    leaving them unresolved even with an ethers file.
    
    Change-Id: Id09bc412adf5d2752155650a14a77c5378af2e42
    Reviewed-on: https://code.wireshark.org/review/9475
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ed21afa   LLDP: fix dissection of Power Class field
    adds  df5a315   Fix address resolution for columns.


Summary of changes:
 epan/addr_resolv.c   |   54 --------------------------------------------------
 epan/addr_resolv.h   |   14 -------------
 epan/address_types.c |   52 ++++++++++++++++++++++++++++++++++++++++++++++++
 epan/column-utils.c  |    2 +-
 epan/to_str.h        |   27 +++++++++++++++++++++++++
 5 files changed, 80 insertions(+), 69 deletions(-)