Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 f144ac4: opcua dissector: Fix parsing of 7 byte numeric service Node

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f144ac433b80d8a6d377dbe39021007bbc5b137c
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f144ac4 by Gerhard Gappmeier (gerhard.gappmeier@xxxxxxxxxxx):

    opcua dissector: Fix parsing of 7 byte numeric service NodeIds.
    
    The service NodeIds of OPC UA are normally encoded as 4 byte numeric NodeId.
    However, it is technically also possible to encode these as (less efficient) 7 byte numeric NodeId.
    This kind of NodeId was already implemented, but wrong.
    Since then no one ever used this kind of NodeId for service NodeIds.
    
    Change-Id: I8654d969604e18bce8415931e455632e72d578ef
    Reviewed-on: https://code.wireshark.org/review/9435
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 9c7acde7125b23fa8c74bd9f6f98a7e940e5c5c8)
    Reviewed-on: https://code.wireshark.org/review/9436
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  80c4add   Explicitly check for DCE/RPC dissector name in the Decode As dialog because it doesn't have a specific subdissector table to invoke the DCE/RPC "Decode As" tab.
    adds  f144ac4   opcua dissector: Fix parsing of 7 byte numeric service NodeIds.


Summary of changes:
 plugins/opcua/opcua_application_layer.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)