Wireshark-commits: [Wireshark-commits] lts-1.12.1 8c69292: lbmr: fix possible infinite loop
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 31 May 2015 19:04:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8c6929254e6b30bc64b6f7e29699085ee2611b93
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

8c69292 by Evan Huus (eapache@xxxxxxxxx):

    lbmr: fix possible infinite loop
    
    Ensure that we handle when option_len is zero so we don't go into an infinite
    loop. Reported by Vlad Tsyrklevich and found by the "joern" tool. Also fix what
    appears to be two misplaced "curr_offset" values which would have resulted in a
    bad loop anyways.
    
    Bug: 11036
    Change-Id: I79e70fcf79015cb0add1744aff695143e11312aa
    Reviewed-on: https://code.wireshark.org/review/7593
    Reviewed-by: David Ameiss <netshark@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    (cherry picked from commit c19860dba8d158c42865c3d9051b6f318cb41169)
    Reviewed-on: https://code.wireshark.org/review/7644
    (cherry picked from commit 524d58583bfadf44df1455ee104234da384c8c7e)
    Reviewed-on: https://code.wireshark.org/review/8634
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  7d1323d   wcp: add validations to decompressed_entry
    adds  8c69292   lbmr: fix possible infinite loop


Summary of changes:
 epan/dissectors/packet-lbmr.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)