Wireshark · Wireshark-commits: [Wireshark-commits] master d555aa7: websocket: restructure tree, always unmask payload

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d555aa759b9fb3199eb5822c20c86ed80c4608d3
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d555aa7 by Peter Wu (peter@xxxxxxxxxxxxx):

    websocket: restructure tree, always unmask payload
    
    Changes:
     - Instead of special-casing masked and unmasked payload data, always
       unmask the payload before using it. This fixes handling of SIP
       requests which are masked and would previously not be dissected by
       the SIP handle. (As a result, many fields are removed).
     - Dissected text protocols (for example SIP) are now shown below the
       Websocket layer instead of inside the payload tree.
     - Use line-based text dissector as fallback for text decoding, and use
       data dissector for binary decoding.
     - Treat the optional close reason as UTF-8 instead of ASCII.
     - Group the close fields (status code, reason) in a subtree below close
       to avoid confusion. Make Close FT_NONE to avoid displaying hex.
     - Split dissection of the payload in separate functions for control and
       data frames.
    
    Change-Id: I78b0078d51271bef94229d4b7c6c528b5e3a424d
    Reviewed-on: https://code.wireshark.org/review/7294
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  b407e45   [Automatic update for 2015-05-31]
    adds  d555aa7   websocket: restructure tree, always unmask payload


Summary of changes:
 epan/dissectors/packet-websocket.c |  329 ++++++++++++++----------------------
 1 file changed, 124 insertions(+), 205 deletions(-)