Wireshark-commits: [Wireshark-commits] master 61cef23: Use an "Open" instead of a "Save" dialog for
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 May 2015 21:16:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=61cef23486d84da0b53107d35d641f15265bef3f
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

61cef23 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Use an "Open" instead of a "Save" dialog for UAT prefs.
    
    When selecting a file for a PT_TXTMOD_FILENAME UAT preference, use
    QFileDialog::getOpenFileName instead of QFileDialog::getSaveFileName.
    This matches current GTK+ behavior and the two preferences that use
    PT_TXTMOD_FILENAME.
    
    Add a comment noting that the PT_TXTMOD_FILENAME is Open-only.
    
    Bug: 11027
    Change-Id: I29eb056422949eda700d448621e508cf094fd7b7
    Reviewed-on: https://code.wireshark.org/review/8678
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  1955dd2   1.99.6 → 1.99.7.
    adds  61cef23   Use an "Open" instead of a "Save" dialog for UAT prefs.


Summary of changes:
 epan/uat.h           |    7 +++++++
 ui/qt/uat_dialog.cpp |    2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)