Wireshark-commits: [Wireshark-commits] master-1.10 b7d2089: Fix integer_to_repr() so that it actual
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 May 2015 01:03:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7d20897e8967794b73a07c22dfc8ac875a12d4c
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

b7d2089 by Jeff Morriss (morriss@xxxxxxxxxxx):

    Fix integer_to_repr() so that it actually does something.
    
    Ie95700295ed707dc7f8c6461b026c67f8c0695c4 was back-ported from a change on
    master but it missed a few (rather important) lines.
    
    (This shows the advantage of compiling the old branches with
    warnings-turned-errors; this showed up immediately as a compile error.)
    
    Change-Id: I46817707b181187731577ab91f2cc7ba08e0e60f
    Reviewed-on: https://code.wireshark.org/review/7819
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit b89ad57ae934611a6b8bd30e8bed6d42c289f997)
    Reviewed-on: https://code.wireshark.org/review/8666
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  373deb5   Include <epan/wmem/wmem.h>, as we use wmem routines.
    adds  b7d2089   Fix integer_to_repr() so that it actually does something.


Summary of changes:
 epan/ftypes/ftype-integer.c |    2 ++
 1 file changed, 2 insertions(+)