Wireshark-commits: [Wireshark-commits] master-1.12 be67bfb: Pop up error dialogs and quit if we don
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 23 May 2015 07:27:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be67bfbe62faf3de2ac4d1d51906e236744e52a8
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

be67bfb by Guy Harris (guy@xxxxxxxxxxxx):

    Pop up error dialogs and quit if we don't have a working X11.
    
    If XQuartz is missing the /usr/X11 symlink but the user doesn't allow us
    to fix it, don't try to run Wireshark.
    
    If the OS has X11 bundled but the user didn't install it, let them know,
    and don't try to run Wireshark.
    
    We should probably just say "your X11/XQuartz is hosed" for other
    problem cases.
    
    Get rid of some debugging fprintfs while we're at it.
    
    Change-Id: I6ef4581e9a45967b4cda709c4be25dad41a9613d
    Reviewed-on: https://code.wireshark.org/review/8598
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  63cfa75   Include XQuartzFixer.c in the tarball.
    adds  be67bfb   Pop up error dialogs and quit if we don't have a working X11.


Summary of changes:
 packaging/macosx/ScriptExec/main.c |  176 +++++++++++++++++++++++++-----------
 1 file changed, 121 insertions(+), 55 deletions(-)