Wireshark-commits: [Wireshark-commits] master 4a4871a: ntlmssp: swap bounds check and length for me
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 May 2015 01:58:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a4871a831bd32fc5b28ec4dd25b52ee4d54e22a
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a4871a by Evan Huus (eapache@xxxxxxxxx):

    ntlmssp: swap bounds check and length for memcpy
    
    The values make more sense swapped (and the code is super-old) so I'm assuming
    this was just a long-uncaught typo. Fixes a valgrind error at any rate.
    
    Also replace a malloc+memcpy with a memdup for simplicity.
    
    Bug: 11203
    Change-Id: I74c0aff548b844cf90610db56a143f3eac172658
    Reviewed-on: https://code.wireshark.org/review/8493
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  d934d40   Update some comments.
    adds  4a4871a   ntlmssp: swap bounds check and length for memcpy


Summary of changes:
 epan/dissectors/packet-ntlmssp.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)