Wireshark-commits: [Wireshark-commits] master 85f38f9: tap: Add ability to reject/ignore "error" pa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 May 2015 12:14:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=85f38f9f75a3c7a41d78ec953ebc23f6439ea426
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

85f38f9 by Evan Huus (eapache@xxxxxxxxx):

    tap: Add ability to reject/ignore "error" packets in tap
    
    ICMP (and a few other protocols) can carry "error packets" as payloads in
    certain cases. In the same way that we don't (by default) call TCP reassembly
    code on TCP packets we know are out-of-order, we also shouldn't call tap code on
    frames carried in ICMP error packets.
    
    Bug: 11184
    Change-Id: Ie83dbb505c8fdc15c5554705488c16fa0274a06a
    Reviewed-on: https://code.wireshark.org/review/8446
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  aa6466a   Main (menubar): fix C++ style comments are not allowed in ISO C90
    adds  85f38f9   tap: Add ability to reject/ignore "error" packets in tap


Summary of changes:
 epan/tap.c |   20 ++++++++++++--------
 epan/tap.h |    3 ++-
 2 files changed, 14 insertions(+), 9 deletions(-)