Wireshark-commits: [Wireshark-commits] master 703b5dc: Qt: Don't set ProtoTree::uniformRowHeights.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 May 2015 19:38:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=703b5dc48a441689738f39641645cbf126a2acfb
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

703b5dc by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Don't set ProtoTree::uniformRowHeights.
    
    Some packet detail items contain multiple lines. Show them, which
    duplicates the GTK+ UI behavior. Add a note about adding a custom item
    delegate if this affects performance.
    
    Make item labels QStrings while we're here.
    
    Bug: 10225
    Change-Id: Ia39320028ecff5fe7fa3e4c09ff37405986b7f6e
    Reviewed-on: https://code.wireshark.org/review/8445
    Tested-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  84db6a6   Fix an error found by Valgrind.
    adds  703b5dc   Qt: Don't set ProtoTree::uniformRowHeights.


Summary of changes:
 ui/qt/proto_tree.cpp |   25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)