Wireshark-commits: [Wireshark-commits] master-1.12 299e206: Backport some parts of I5573c6bdca856a3
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 May 2015 17:10:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=299e2067b8a468b4f5d721f46f8bb620eab8b4ec
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

299e206 by Guy Harris (guy@xxxxxxxxxxxx):

    Backport some parts of I5573c6bdca856a304877d9bef643f8c0fa93cdaf.
    
    Backport the parts of
    
      commit 56a09d24dcdcaddae1cb67a18bbc2fd588c427ed
      Author: Michal Labedzki <michal.labedzki@xxxxxxxxx>
      Date:   Wed Jul 23 12:26:05 2014 +0200
    
          Try to fix some buildbot warnings
    
          Most interesting are:
           warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations]
           warning: ISO C forbids zero-size array [-Wpedantic]
           warning: ISO C90 doesn't support unnamed structs/unions [-Wpedantic]
           warning: cast discards '__attribute__((const))' qualifier from pointer target type [-Wcast-qual
           warning: initializer element is not computable at load time [enabled by default]
    
          Change-Id: I5573c6bdca856a304877d9bef643f8c0fa93cdaf
          Reviewed-on: https://code.wireshark.org/review/3174
          Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
          Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
          Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    
    relevant to this version of wiretap/logcat.c.  They fix "ISO C forbids
    zero-size array"; not all compilers we support allow zero-size arrays.
    
    They also make the code a bit more like the version on the trunk.
    
    Change-Id: I6524a8c05c1d945312ec1db7c305422f1021ef2c
    Reviewed-on: https://code.wireshark.org/review/8431
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  09eda88   Reduce compilator warnings
    adds  299e206   Backport some parts of I5573c6bdca856a304877d9bef643f8c0fa93cdaf.


Summary of changes:
 wiretap/logcat.c |   31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)