Wireshark-commits: [Wireshark-commits] master d1f7823: Fix Diameter reassembly when the captured tv
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 May 2015 13:09:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d1f78230c9dcc631659f3e5f0008bf01115c2d69
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d1f7823 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Fix Diameter reassembly when the captured tvb length is less than 5 bytes.
    
    Since Diameter does heuristic checks before calling tcp_dissect_pdus() we
    have to "manually" ask for more data if the tvb is too short for our
    heuristics.
    
    Bug: 11183
    Change-Id: I14c36042306b532b53df80cc3971866b76094084
    Reviewed-on: https://code.wireshark.org/review/8405
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  b708c4a   Diameter: Add support for Sd interface
    adds  d1f7823   Fix Diameter reassembly when the captured tvb length is less than 5 bytes.


Summary of changes:
 epan/dissectors/packet-diameter.c |   36 +++++++++++++++++++++++++-----------
 1 file changed, 25 insertions(+), 11 deletions(-)