Wireshark-commits: [Wireshark-commits] master 8035807: Add/clarify some comments about how the Expe
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 6 May 2015 20:27:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80358079fe0a7c620b58d3109bfe1ba7e9bf8e3c
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8035807 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Add/clarify some comments about how the Experimental-Result-Code AVP is handled.
    
    Specifically we put Experimental-Result-Codes specified by 3GPP in the XML file
    and let other vendors' codes be handled through a dissector table.
    
    Change-Id: I2c3977fb959ad84faa5cb90aeb3d191c8b465ede
    Reviewed-on: https://code.wireshark.org/review/8319
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  0f55a0f   Have global_capture_opts if we either have pcap or extcap.
    adds  8035807   Add/clarify some comments about how the Experimental-Result-Code AVP is handled.


Summary of changes:
 diameter/dictionary.xml           |   13 ++++++++++++-
 epan/dissectors/packet-diameter.c |   26 +++++++++++++++-----------
 2 files changed, 27 insertions(+), 12 deletions(-)